Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite): make SubscriberClient.Receive identical to pubsub #4281

Merged
merged 4 commits into from Jun 22, 2021
Merged

fix(pubsublite): make SubscriberClient.Receive identical to pubsub #4281

merged 4 commits into from Jun 22, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 17, 2021

  • Ensures that pscompat.SubscriberClient.Receive and pubsub.Subscription.Receive have identical interfaces.
  • Adds examples for how to declare common interfaces for pubsublite and pubsub.
  • Amended docs to point to these examples.
  • Other misc doc cleanups.

@tmdiep tmdiep requested review from a team as code owners June 17, 2021 23:34
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jun 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2021
@tmdiep tmdiep requested review from hongalex and codyoss June 17, 2021 23:43
@tmdiep tmdiep mentioned this pull request Jun 17, 2021
Closed
codyoss
codyoss approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tmdiep
Copy link
Contributor Author

tmdiep commented Jun 22, 2021

Thanks for reviewing!

@tmdiep tmdiep merged commit 5b5d0f7 into googleapis:master Jun 22, 2021
@tmdiep tmdiep deleted the pubsub_interfaces branch June 22, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@hongalex hongalex Awaiting requested review from hongalex

Assignees
No one assigned
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmdiep @codyoss