Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix Writer.ChunkSize validation #4255

Merged
merged 2 commits into from Jun 14, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jun 14, 2021

Since w.opened is set to true before this validation currently,
subsequent calls to Writer.Close will deadlock. There is no
reason not to do this check first before opening the pipe.

Thanks to @dt for pointing this out.

Updates #4167

Since w.opened is set to true before this validation currently,
subsequent calls to Writer.Close will deadlock. There is no
reason not to do this check first before opening the pipe.

Thanks to @dt for pointing this out.

Updates googleapis#4167
@tritone tritone requested a review from a team June 14, 2021 04:05
@tritone tritone requested a review from a team as a code owner June 14, 2021 04:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 14, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 69c2e9d into googleapis:master Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@tritone tritone deleted the chunksize-fix branch June 14, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants