feat(pubsub/pstest): add channel to support user-defined publish responses #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
shollyman
approved these changes
Jun 15, 2021
| @@ -613,6 +658,15 @@ func (s *GServer) Publish(_ context.Context, req *pb.PublishRequest) (*pb.Publis | |||
| if top == nil { | |||
| return nil, status.Errorf(codes.NotFound, "topic %q", req.Topic) | |||
| } | |||
|
|
|||
| if !s.autoPublishResponse { | |||
| r := <-s.publishResponses | |||
There was a problem hiding this comment.
Unclear if it matters, but do you want blocking behavior here, or should it emit an error in the case of some kind of timeout via a select loop or similar?
There was a problem hiding this comment.
I want blocking behavior, but could be convinced to add a timeout/error in the future.
kamalaboulhosn
approved these changes
Jun 15, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.12.0](https://www.github.com/googleapis/google-cloud-go/compare/pubsub/v1.11.0...pubsub/v1.12.0) (2021-06-23) ### Features * **pubsub/pstest:** add channel to support user-defined publish responses ([#4251](https://www.github.com/googleapis/google-cloud-go/issues/4251)) ([e1304f4](https://www.github.com/googleapis/google-cloud-go/commit/e1304f435fed4a767f4a652f32f1386979ff794f)) ### Bug Fixes * **pubsub:** fix memory leak issue in publish scheduler ([#4282](https://www.github.com/googleapis/google-cloud-go/issues/4282)) ([22ffc18](https://www.github.com/googleapis/google-cloud-go/commit/22ffc18e522c0f943db57f8c943e7356067bedfd)) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the Java fake publisher service, these changes improves testing by allowing users to specify
PublishResponsesthat the fake server will return forPublishcalls.This is implemented with a buffered publishResponses channel, that users can add to by disabling automatic publish responses (the current behavior) and calling
AddPublishResponse.Lastly, the default buffered channel size is 100 (an arbitrary number suitable for testing). If the size needs to be increased, or you want to reset the publish queue, call
ResetPublishResponses.The changes in this PR will be used to help test publisher flow control.