Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): ensure api clients are closed when startup fails #4239

Merged
merged 2 commits into from Jun 10, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 9, 2021

  • Ensure that NewSubscriber and NewPublisher constructors close all created API clients if they partially fail.
  • Added an apiClientService base class to handle closing clients when startup fails, as well as after shutdown.

@tmdiep tmdiep requested review from a team as code owners June 9, 2021 23:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Jun 9, 2021
@tmdiep tmdiep merged commit 55025a1 into googleapis:master Jun 10, 2021
@tmdiep tmdiep deleted the clients_close branch June 10, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants