fix(logging): Support numbers when unmarshaling Severity #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging.Entry.Severity is written out as a JSON number during Marshalling but has an UnmarshalJSON method that only supports Severity as as string. This commit adds support to unmarshal JSON numbers in addition to strings so Marshalling then Unmarshalling the same object works without error
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: logging
0xSage
added
kokoro:force-run
0xSage
approved these changes
Jun 4, 2021
|
Thanks for this! |
kokoro-team
removed
kokoro:run
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
|
@alutman do you want us to merge this - is it ready? With how CI is configured and given this repo has a lot of PRs updating changes, you mgiht be stuck in a cycle of having to update this branch, and then wait for someone internal to approve HEAD, in order for CI to run, before it can be merged Let us know if this PR is ready, and I can merge for you. |
0xSage
added
kokoro:force-run
kokoro-team
removed
kokoro:run
|
@nicoleczhu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging.Entry.Severity is written out as a JSON number during
Marshalling but has an UnmarshalJSON method that only supports Severity
as as string.
This commit adds support to unmarshal JSON numbers in addition to
strings so Marshalling then Unmarshalling the same object works without
error
Fixes #4215