feat(firestore): Add support for PartitionQuery #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific locations for CMEK
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
tritone
reviewed
Jun 9, 2021
|
Also, just realized there was #3476 previously (integration test there is interesting). |
… into partition-query
…so paths are relative for start/end val
… need to try and interpret later if a path is valid
crwilcox
force-pushed
the
partition-query
branch
from
93146fd
to
f145f48
Compare
crwilcox
force-pushed
the
partition-query
branch
from
f145f48
to
1d74b53
Compare
…e rest as internal impl?
tritone
reviewed
Jun 24, 2021
| // TODO: add a fromProto to compliment toProto for query. With that serialization is | ||
| // very possible. user could also do json.Marshal(toProto()) | ||
|
|
||
| // GetPartitionedQueries returns a slice of Query objects, each containing a |
There was a problem hiding this comment.
Since all the other types/methods are now non-exported, this is the only thing that will go into the public package docs. Is there more to add here? Is there a link to the docs on cloud site for this feature?
There was a problem hiding this comment.
At the current point we don't have any docs really, other than rest docs, which I am not sure will bring clarity: https://firebase.google.com/docs/firestore/reference/rest/v1beta1/projects.databases.documents/partitionQuery
noahdietz
reviewed
Jun 24, 2021
noahdietz
reviewed
Jun 24, 2021
noahdietz
reviewed
Jun 24, 2021
noahdietz
reviewed
Jun 24, 2021
noahdietz
approved these changes
Jun 25, 2021
tritone
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other implementations of this:
Java
Merged googleapis/java-firestore@3996548
googleapis/java-firestore#202 (“add support for QueryPartition API”)
googleapis/java-firestore#418 (“verify page count before invoking QueryPartition RPC”)
googleapis/java-firestore#417 (“add implicit ordering for startAt(DocumentReference) calls”)
Released in java-firestore v2.0.0
Node.js
googleapis/nodejs-firestore#1320 (“add support for QueryPartition API”)
googleapis/nodejs-firestore#1328 (“add implicit ordering for startAt(DocumentReference) calls”)
Merged. https://github.com/googleapis/nodejs-firestore/pull/1110/files#diff-487a284b3e5f6cec3fe8dc89ea74120d