Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigtable/bttest: ModifyColumnFamilies should be synchronous and blocking #4202

Closed
dragonsinth opened this issue Jun 2, 2021 · 3 comments
Closed
Assignees
Labels
api: bigtable Issues related to the Bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dragonsinth
Copy link
Contributor

Expected behavior

In production bigtable, ModifyColumnFamilies is a slow-running operation. Once complete, any dropped column families will no longer be returned by row scans. bigtable emulator should replicate this behavior. An example flow:

  • ModifyColumnFamilies to remove column family "foo"
  • ModifyColumnFamilies to add column family "foo" back
  • RowScan does not return any data from the "foo" column family.

Tested vs. production bigtable.

Actual behavior

bttest's ModifyColumnFamilies returns quickly and leaves the actual data purge up to background garbage collection. Subsequent row scans can return data that doesn't exist. If a column family is re-created in the interim, the data is never purged. An example flow:

  • ModifyColumnFamilies to remove column family "foo"
  • ModifyColumnFamilies to add column family "foo" back
  • RowScan returns old data from before the modify calls
@dragonsinth dragonsinth added the triage me I really want to be triaged. label Jun 2, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 2, 2021
@dragonsinth
Copy link
Contributor Author

#4096

@crwilcox crwilcox added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 2, 2021
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jun 3, 2021
@jimfulton
Copy link
Contributor

@crwilcox It looks like this should be closed.

@dragonsinth
Copy link
Contributor Author

Same comment: It's definitely fixed, but I'm not sure how things work regarding linking issues to particular releases; some projects don't close issues into a release happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

5 participants