Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): add missing NUMERIC type to the doc for Row #4116

Merged
merged 2 commits into from Jun 2, 2021
Merged

fix(spanner): add missing NUMERIC type to the doc for Row #4116

merged 2 commits into from Jun 2, 2021

Conversation

yfuruyama
Copy link
Contributor

I found NUMERIC data type is missing in the doc for Row, so added to the doc.

@yfuruyama yfuruyama requested review from hengfengli, skuruppu and a team as code owners May 18, 2021 09:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 18, 2021
hengfengli
hengfengli approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 18, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 18, 2021
@hengfengli hengfengli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@hengfengli hengfengli merged commit 9a3b416 into googleapis:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yfuruyama @hengfengli @kokoro-team