Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): Guard for nil EncryptionConfig in Clusters, GetCluster #4113

Merged

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented May 17, 2021

Fixes #4105

@crwilcox crwilcox requested review from kolea2, tritone and a team as code owners May 17, 2021 23:34
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2021
@crwilcox crwilcox changed the title fix(bigtable): Fixes #4105 by guarding on nil EncryptionConfig fix(bigtable): Guard for nil EncryptionConfig in Clusters, GetCluster May 17, 2021
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that can add a case for this?

@crwilcox
Copy link
Contributor Author

@tritone there is already a test that should have failed, however as they are authored and ordered the integration suite can't all pass, all fail. I have it on my list to fix and improve.

@crwilcox crwilcox merged commit a17ff67 into googleapis:master May 18, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 2, 2021
@crwilcox crwilcox deleted the guard-against-nil-encryption-config branch October 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable: Panic when listing instance clusters without KmsKeyName
3 participants