Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add support for snapshot/restore #4112

Merged
merged 9 commits into from Jun 22, 2021

Conversation

shollyman
Copy link
Contributor

Secondary changes: This complicated some internal wrapping functions
for TableMetadata. The fact that TableMetadata can now contain a Table
reference for other tables means we need to pass around an additional
instance of the Client, as user may want to do something like call
Metadata() on the embedded reference to the base table in a
snapshot definition.

Secondary changes:  This complicated some internal wrapping functions
for TableMetadata.  The fact that TableMetadata can now contain a Table
reference for other tables means we need to pass around an additional
instance of the Client, as user may want to do something like call
Metadata() on the embedded reference to the base table in a
snapshot definition.
@shollyman shollyman requested a review from a team as a code owner May 17, 2021 21:31
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label May 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2021
@shollyman shollyman requested review from codyoss and tbpg June 15, 2021 15:55
bigquery/integration_test.go Outdated Show resolved Hide resolved
bigquery/integration_test.go Outdated Show resolved Hide resolved
bigquery/table.go Show resolved Hide resolved
@shollyman shollyman requested a review from tbpg June 17, 2021 20:45
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman merged commit 4c12b42 into googleapis:master Jun 22, 2021
@shollyman shollyman deleted the fr-snapshot-support branch June 22, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants