Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable/bttest): fix ModifyColumnFamilies to purge data #4096

Merged
merged 5 commits into from Jun 4, 2021
Merged

fix(bigtable/bttest): fix ModifyColumnFamilies to purge data #4096

merged 5 commits into from Jun 4, 2021

Conversation

dragonsinth
Copy link
Contributor

  • Adds TestModifyColumnFamilies to test that it works

Tested vs. real bigtable.

@dragonsinth dragonsinth requested review from crwilcox, kolea2, tritone and a team as code owners May 12, 2021 23:49
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2021
@dragonsinth
Copy link
Contributor Author

@jhump

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2021
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2021
@dragonsinth dragonsinth mentioned this pull request Jun 2, 2021
Closed
@dragonsinth
Copy link
Contributor Author

#4202

crwilcox
crwilcox approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorbernstein2 ?

@dragonsinth
fix(bigtable/bttest): fix ModifyColumnFamilies to purge data
8c27fde 
- Adds TestModifyColumnFamilies to test that it works
@dragonsinth
Copy link
Contributor Author

(manually resolved merge and force-pushed)

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021
@crwilcox crwilcox added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 4, 2021
@dragonsinth
Copy link
Contributor Author

I'm not really sure what went wrong 🤷

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@crwilcox crwilcox added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2021
@crwilcox
Copy link
Contributor

crwilcox commented Jun 4, 2021

@dragonsinth our automation was unable to merge as other changes occurred. I will update the branch and rerun our tests ;)

@gcf-merge-on-green gcf-merge-on-green bot merged commit 2095028 into googleapis:master Jun 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 4, 2021
@dragonsinth dragonsinth deleted the bttest-dropfam branch June 4, 2021 19:33
@dragonsinth
Copy link
Contributor Author

Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

@tritone tritone Awaiting requested review from tritone

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dragonsinth @crwilcox @tritone @kokoro-team