fix(bigtable/bttest): emulator too lenient regarding RowFilter and CheckAndMutateRow conditions #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragonsinth
commented
May 12, 2021
dragonsinth
commented
- Sanitize some test requests to include Mutations (these are rejected by real bigtable)
- Sanitize Chain and Interleave filters to have at least 2 (these are rejected by real bigtable)
- BlockAllFilter and PassAllFilter are required to be true
- bttest emulates some of these error conditions
- Sanitize some test requests to include Mutations (these are rejected by real bigtable) - Sanitize Chain and Interleave filters to have at least 2 (these are rejected by real bigtable) - BlockAllFilter and PassAllFilter are required to be true - bttest emulates some of these error conditions
dragonsinth
requested review from
crwilcox,
kolea2,
tritone and
a team
as code owners
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
|
I've recently been running the bttest cases against a live bigtable server, and these are the errors I ran into. |
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
crwilcox
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dragonsinth
changed the title
crwilcox
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
igorbernstein2
approved these changes
Jun 3, 2021
crwilcox
added
automerge
kokoro-team
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.