Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): augment retry predicate to support additional errors #4046

Merged
merged 3 commits into from May 3, 2021

Conversation

shollyman
Copy link
Contributor

Based on similar refactor in storage:
#4019

Fixes: #4021

@shollyman shollyman requested a review from a team as a code owner May 3, 2021 21:50
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label May 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2021
@shollyman shollyman requested a review from tritone May 3, 2021 21:50
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just on small comment.

bigquery/bigquery.go Show resolved Hide resolved
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We also added io.ErrUnexpectedEOF for storage; not sure whether or not that makes sense for you.

bigquery/bigquery.go Show resolved Hide resolved
@shollyman
Copy link
Contributor Author

Looks good! We also added io.ErrUnexpectedEOF for storage; not sure whether or not that makes sense for you.

Haven't seen this in the wild, but I see there's a few common imports that traffic it (http and grpc). I'll add it.

@shollyman shollyman merged commit d4af6f7 into googleapis:master May 3, 2021
@shollyman shollyman deleted the fr-better-errors branch May 3, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery: client does not retry transient, low-level errors
3 participants