New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner/spansql): case insensitive parsing of keywords and functions #4034
feat(spanner/spansql): case insensitive parsing of keywords and functions #4034
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@dsymonds Can you please rebase this branch? Thanks. |
Rebased! |
Missed the chance to merge again, :-(. I will try to rebase it if I can. |
I don't see a button on this PR to allow me to rebase it. Also, I tried to bring the PR to local and rebase it. But when I push it, it gets rejected. @dsymonds can you please rebase it again? sorry for the trouble. |
…ions This handles the most important parts of the parser as it relates to case insensitivity, namely permitting the lexical tokens for the grammar (as opposed to elements like table/column names) to have arbitrary case. This includes a complete audit of the parser to check all the lexical token handling, and cleaned up a few places that were particularly ancient. The rendered output remains canonically uppercase. Fixes #4032.
rebased, @hengfengli |
This handles the most important parts of the parser as it relates to
case insensitivity, namely permitting the lexical tokens for the grammar
(as opposed to elements like table/column names) to have arbitrary case.
This includes a complete audit of the parser to check all the lexical
token handling, and cleaned up a few places that were particularly
ancient.
The rendered output remains canonically uppercase.
Fixes #4032.