New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigtable): allow restore backup to different instance (#3489) #4014
Conversation
* feat: restore table to a different instance * add check that table restored * review fixes * change instance config zone
…ackup-different-instance # Conflicts: # bigtable/admin.go
@liubonan fyi |
https://github.com/golang/go/wiki/TestComments#keep-going is relevant to using |
…gle-cloud-go into backup-different-instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, a few more testing Q's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments. Overall, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comment comments. Looks good.
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
feat: restore table to a different instance
add check that table restored
review fixes
change instance config zone