Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): fix failing message storage policy tests #4003

Merged
merged 2 commits into from Apr 23, 2021

Conversation

hongalex
Copy link
Member

Due to new internal org level policies, we don't have a consistent set of initial message storage policy regions. This PR refactors tests to make them not dependent on any initial region set.

In addition, cleans up the update labels test by removing the check for the unrelated message storage policy field.

Fixes #3065

@hongalex hongalex requested review from a team as code owners April 23, 2021 21:56
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: check message storage policy reasons in integration test
2 participants