fix(logging): allow nil zones in resource autodetection #3997
Conversation
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: logging
| if cutoff > 0 { | ||
| return zone[:cutoff] | ||
| } | ||
| return zone |
There was a problem hiding this comment.
If this value is not what is expected should we put zone in at all? Or just ""?
There was a problem hiding this comment.
Maybe I can help out here, in my experience, passing in the values causing this to panic (e.g. us16) will work and be accepted by Cloud Logging. I've been using my own autodetect code to stand up our logging client which does this and have had no issues logging:
There was a problem hiding this comment.
We should accept any user specified/custom zones. Per user docs:
CommonResource sets the monitored resource associated with all log entries written from a Logger. If not provided, the resource is automatically detected based on the running environment (on GCE, GCR, GCF and GAE Standard only). This value can be overridden per-entry by setting an Entry's Resource field.
|
@codyoss , can I bug you for a stampy stamp on this one? |
oh wow, thank you for taking a look on your weekend Cody |
fixes #3990