fix(pubsub): make config call permission error in Receive transparent #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
fix(pubsub): make config call permission error in Receive transparent remove extra whitespace clarify doc comments fix typos fix formatting
hongalex
force-pushed
the
pubsub-config-call-check
branch
from
f309ba7
to
adad575
Compare
…-cloud-go into pubsub-config-call-check
…-cloud-go into pubsub-config-call-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3886, a
Subscription.Config()call was added to check forEnableMessageOrderingon the subscription before delivering messages with ordering keys in order. This negatively affected users who didn't have the roles/viewer or roles/pubsub.viewer roles on their service account.This PR incorporates two changes:
Config()is only done (once) when we detect an ordering key in a received message.Fixes #3947