Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/gensnippets): initial commit #3922

Merged
merged 2 commits into from Apr 13, 2021
Merged

feat(internal/gensnippets): initial commit #3922

merged 2 commits into from Apr 13, 2021

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Apr 13, 2021

This tool renders all examples in the current directory to standalone
files.

I confirmed this successfully processes every example in this repo. Once
I added a go.mod/go.sum in the generated directory, all of the examples
passed go vet.

A future change will integrate this tool into our automatic generation
pipelines and add region tags.

This tool renderes all examples in the current directory to standalone
files.

I confirmed this successfully processes every example in this repo. Once
I added a go.mod/go.sum in the generated directory, all of the examples
passed go vet.

A future change will integrate this tool into our automatic generation
pipelines and add region tags.
@tbpg tbpg requested review from codyoss and noahdietz April 13, 2021 15:40
@tbpg tbpg requested a review from a team as a code owner April 13, 2021 15:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a couple small things.

internal/gensnippets/main.go Outdated Show resolved Hide resolved
internal/gensnippets/main.go Outdated Show resolved Hide resolved
internal/gensnippets/main.go Show resolved Hide resolved
internal/gensnippets/main.go Show resolved Hide resolved
Copy link
Contributor Author

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

internal/gensnippets/main.go Show resolved Hide resolved
internal/gensnippets/main.go Outdated Show resolved Hide resolved
internal/gensnippets/main.go Outdated Show resolved Hide resolved
internal/gensnippets/main.go Show resolved Hide resolved
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tbpg tbpg merged commit 3fabef0 into master Apr 13, 2021
@tbpg tbpg deleted the gensnippets branch April 13, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants