Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): cloud run and functions resource autodetection #3909

Merged
merged 10 commits into from Apr 14, 2021

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Apr 9, 2021

Fixes: #3486

Changes:

  • cloud run has correct resource labels and type
  • functions has correct resource labels and type
  • e2e environment tests covered here

@0xSage 0xSage self-assigned this Apr 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Apr 9, 2021
@0xSage 0xSage changed the title feat(logging): cloud run resource autodetection feat(logging): cloud run and functions resource autodetection Apr 9, 2021
@0xSage 0xSage marked this pull request as ready for review April 9, 2021 21:56
@0xSage 0xSage requested review from a team as code owners April 9, 2021 21:56
Copy link

@simonz130 simonz130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you!

logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
logging/logging.go Outdated Show resolved Hide resolved
logging/logging.go Show resolved Hide resolved
@0xSage
Copy link
Contributor Author

0xSage commented Apr 13, 2021

Ready for another look @simonz130 or @daniel-sanche when you have time
@daniel-sanche I realize the library memoizes already. detectResource is run once upon logger initialization

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@0xSage 0xSage added priority: p2 Moderately-important priority. Fix may not be included in next release. automerge Merge the pull request once unit tests and other checks pass. labels Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging: resource autodetection for CloudRun
4 participants