fix(pubsub): respect subscription message ordering field in scheduler #3886
Conversation
google-cla
bot
added
the
cla: yes
|
@hongalex |
| if err != nil { | ||
| return fmt.Errorf("sub.Config err: %v", err) | ||
| } | ||
| s.enableOrdering = cfg.EnableMessageOrdering |
There was a problem hiding this comment.
Related doc
There was a problem hiding this comment.
This page does not explicitly call out why we're setting EnableMessageOrdering, aside from the code sample, so I'm inclined to leave this out.
There was a problem hiding this comment.
👍
My comment was more like - look there is an example where this property is mentioned.
This was a good read too:
https://medium.com/google-cloud/google-cloud-pub-sub-ordered-delivery-1e4181f60bc8
These two properties allow publishers and subscribers to decide independently if messages are ordered. If the publisher does not specify ordering keys with messages or the subscriber does not enable ordered delivery, then message delivery is not in order and behaves just like Cloud Pub/Sub without the ordered delivery feature. Not all subscriptions on a topic need to have the same setting for enable_message_ordering. Therefore, different use cases that receive the same messages can determine if they need ordered delivery without impacting each other.
Fixes #3884