fix(pubsublite): improve handling of backend unavailability #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
- define ErrBackendUnavailable - mitigate stream initialization delays
tmdiep
force-pushed
the
unavailable_error
branch
from
19bdac1
to
75fdabe
Compare
tmdiep
force-pushed
the
unavailable_error
branch
from
51f23f8
to
d554104
Compare
manuelmenzella-google
requested changes
Mar 25, 2021
pubsublite/internal/wire/settings.go
Outdated
| @@ -82,7 +82,7 @@ var DefaultPublishSettings = PublishSettings{ | |||
| DelayThreshold: 10 * time.Millisecond, | |||
| CountThreshold: 100, | |||
| ByteThreshold: 1e6, | |||
| Timeout: 60 * time.Minute, | |||
| Timeout: 72 * time.Hour, | |||
There was a problem hiding this comment.
This feels a little arbitrary. Is there an InfiniteFuture() equivalent on Go? Same comment on the ReceiveSettings.
There was a problem hiding this comment.
There isn't a defined infinite duration. It's an int64, so we can compute the max value, however I wanted to avoid depending on implementation details.
I changed this to 1 week, as it would be concerning if a client wasn't able to connect within that time. The original 3 days was to allow clients to cover a weekend.
manuelmenzella-google
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrBackendUnavailableto allow users to detect and handle backend unavailability during publish and subscribe.PublishSettings.TimeoutandReceiveSettings.Timeoutto 1 week.PublishSettings.BufferedByteLimitto 10 GB.