fix(pubsublite): fix committer races #3810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Races:
Stop
is called beforeTerminate
when there are outstanding acks, the committer did not transition toserviceTerminated
.Terminate
clears outstanding acks, sounsafeCheckDone
needs to be called to check whether the committer can now shut down.Stop
orTerminate
are called just before the stream is connected, it can send a commit to the server beforeonStreamStatusChange
performs the necessary state initialization for thestreamConnected
signal. So we add anenableCommits
flag to ensureonStreamStatusChange
processes thestreamConnected
signal first.Simplified TestAssigningSubscriberIgnoreOutstandingAcks, which detected these races.
Fixes #3791.