fix(spanner/spansql): fix parsing of NOT IN operator #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
/cc @sryoya |
skuruppu
approved these changes
Feb 23, 2021
skuruppu
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Thanks, can you submit @skuruppu? I no longer have access to do that. |
skuruppu
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@dsymonds for some reason, I'm not able to click a button to update the branch to pick up latest changes from main. |
The parsing of comparison operators was erroneously capturing any NOT token assuming it would be followed by a LIKE or BETWEEN. Instead, change that code to explicitly look ahead for the limited combinations allowed, and do the same for parsing IN and NOT IN. Fixes #3715.
|
Okay, manually rebased. Try again please. |
|
Seems good. Now waiting for Kokoro to run. |
skuruppu
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
skuruppu
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of comparison operators was erroneously capturing any NOT
token assuming it would be followed by a LIKE or BETWEEN. Instead,
change that code to explicitly look ahead for the limited combinations
allowed, and do the same for parsing IN and NOT IN.
Fixes #3715.