fix(pubsublite): change pubsub.Message.ID to an encoded publish.Metadata #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
tmdiep
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Note: as was done for the Java lib in googleapis/java-pubsublite#482, we will rename the publish metadata to MessageMetadata. This will be done in a subsequent PR to isolate unrelated changes and add other reviewers for the public API change. |
manuelmenzella-google
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the Java implementation: googleapis/java-pubsublite#482. If the user's custom message transformer sets the
pubsub.Message.ID, theSubscriberClientwill terminate with error. The internal wire subscriber needs to pass the partition number to the CPS subscriber shim viaReceivedMessage.Updated tests and documentation. Changed the comments for
publish.ParseMetadatato inline documentation examples.