feat(pubsublite): allow increasing the number of topic partitions #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmdiep
added
the
do not merge
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
palmere-google
approved these changes
Feb 8, 2021
hongalex
reviewed
Feb 17, 2021
| @@ -189,6 +189,7 @@ func TestIntegration_ResourceAdminOperations(t *testing.T) { | |||
|
|
|||
| topicUpdate1 := TopicConfigToUpdate{ | |||
| Name: topicPath, | |||
| PartitionCount: 2, | |||
There was a problem hiding this comment.
What happens when a PartitionCount doesn't change? Will the server throw an error here?
There was a problem hiding this comment.
Good question. I just tried it and it's a no-op.
tmdiep
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows increasing the number of partitions when updating a topic config. Updates documentation, examples and integration tests.
Will not be merged until server changes have been fully rolled out.