Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): address a missing branch in watch.stop() error remapping #3643

Merged
merged 4 commits into from Feb 2, 2021

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Feb 1, 2021

While debugging another issue, I came across what appears to be a missing branch

@crwilcox crwilcox requested a review from jba February 1, 2021 18:40
@crwilcox crwilcox requested review from tritone and a team as code owners February 1, 2021 18:40
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Feb 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2021
s.err = err
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, prefer not including else blocks: https://golang.org/doc/effective_go.html#if

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to make this a return. I am going to wait for @jba to maybe weigh in. Since this is either code that should have been removed, or this branch was missed :)

@jba
Copy link
Contributor

jba commented Feb 1, 2021

Wow, that is definitely a bug. Thanks for catching. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants