fix(spanner/spannertest): support queries in ExecuteSql #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normal queries from the Spanner client use the ExecuteStreamingSql method, while DML statements use ExecuteSql. This distinction was also built into spannertest where ExecuteSql would only support DML statements and required a transaction to be specified. The session pool however uses ExecuteSql to execute a simple `SELECT 1` query without specifying any transaction. This would cause a nil pointer dereference. This PR introduces support for queries in the ExecuteSql method. The current logic assumes that the statement is a query if the transaction is a single- use read-only transaction. Fixes #3639
google-cla
bot
added
the
cla: yes
dsymonds
approved these changes
Feb 1, 2021
olavloite
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
|
@skuruppu Apparently your review is also required in this case to allow merging. |
skuruppu
approved these changes
Feb 3, 2021
olavloite
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal queries from the Spanner client use the ExecuteStreamingSql method,
while DML statements use ExecuteSql. This distinction was also built into
spannertest where ExecuteSql would only support DML statements and required
a transaction to be specified. The session pool however uses ExecuteSql to
execute a simple
SELECT 1query without specifying any transaction. Thiswould cause a nil pointer dereference.
This PR introduces support for queries in the ExecuteSql method. The current
logic assumes that the statement is a query if the transaction is a single-
use read-only transaction.
Fixes #3639