feat(storage): support PublicAccessPrevention #3608
Conversation
This is a new field in the IAM configuration for buckets. Support viewing/setting via bucket attrs, and add an integration test for the feature. Closes googleapis#3203
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
storage/bucket.go
Outdated
| // enforces Public Access Prevention on the bucket. | ||
| PublicAccessPreventionEnforced | ||
|
|
||
| publicAccessPreventionDefault string = "" |
There was a problem hiding this comment.
I think the naming of this field might be confusing. Public Access Prevention defaults to 'unspecified'. It will never hold a blank value. I'm trying to think of another option.
There was a problem hiding this comment.
Agreed on this one-- I was trying to follow https://google.aip.dev/126 but it suggests "unspecified" for a zero value. 😆 Suggestions welcome!
There was a problem hiding this comment.
Went for "unknown" here instead.
Adds samples for 3 new region tags for PublicAccessPrevention feature. See library PR at googleapis/google-cloud-go#3608
frankyn
added
the
do not merge
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@tritone , We would like to merge and release this feature next Monday (06/14/21). Does that work for you? |
|
Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details. |
|
@tritone This feature can now be merged and released. |
tritone
removed
the
do not merge
Adds samples for 3 new region tags for PublicAccessPrevention feature. See library PR at googleapis/google-cloud-go#3608
Adds samples for 3 new region tags for PublicAccessPrevention feature. See library PR at googleapis/google-cloud-go#3608
This is a new field in the IAM configuration for buckets.
Support viewing/setting via bucket attrs, and add an integration
test for the feature.
Closes #3203