fix(pubsublite): ignore outstanding acks for removed partition subscribers #3597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
assigningSubscriber
removes asinglePartitionSubscriber
, it should ignore unacked messages when shutting it down (we still attempt to flush the commit cursor for messages that were already acked). This avoids conflicting with the commits from the new subscriber that will be assigned the partition.Alternatively, we can wait for user code to ack all received messages before acking the new assignment. But this will delay the reassignment operation if user code is taking too long to ack the message.