Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable): replace unsafe exec in cbt #3591

Merged
merged 2 commits into from Jan 21, 2021
Merged

fix(bigtable): replace unsafe exec in cbt #3591

merged 2 commits into from Jan 21, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jan 21, 2021

Replace exec with execabs in this cbt command due to a
vulnerability on Windows. See https://blog.golang.org/path-security
for more information.

@tritone
fix(bigtable): replace unsafe exec in cbt
7ce5d08 
Replace exec with execabs in this cbt command due to a
vulnerability on Windows. See https://blog.golang.org/path-security
for more information.
@tritone tritone requested review from igorbernstein2, kolea2 and a team January 21, 2021 16:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 21, 2021
tbpg
tbpg approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Jan 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7c1b0c2 into googleapis:master Jan 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@tbpg tbpg tbpg approved these changes

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2

@kolea2 kolea2 Awaiting requested review from kolea2

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tritone @enocom @tbpg