Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner/spansql): fix SelectFromJoin behavior #3571

Merged
merged 1 commit into from Jan 19, 2021
Merged

fix(spanner/spansql): fix SelectFromJoin behavior #3571

merged 1 commit into from Jan 19, 2021

Conversation

ww24
Copy link
Contributor

@ww24 ww24 commented Jan 16, 2021

Fix #3570

@ww24 ww24 requested review from skuruppu and a team as code owners January 16, 2021 10:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2021
@ww24 ww24 changed the title Fix spansql.SelectFromJoin behavior fix(spanner/spansql): fix SelectFromJoin behavior Jan 16, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 17, 2021
dsymonds
dsymonds approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@dsymonds dsymonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsymonds dsymonds added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 19, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e0887c7 into googleapis:master Jan 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2021
@ww24 ww24 deleted the fix-3570 branch January 19, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsymonds dsymonds dsymonds approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner/spansql: ON clause is missing in JOIN query
3 participants
@ww24 @dsymonds @kokoro-team