Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(networkconnectivity): initial generation of apiv1alpha1 #3567

Merged
merged 7 commits into from Jan 25, 2021

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 15, 2021

Initial generation of network connectivity.

@bcoe bcoe requested a review from a team as a code owner January 15, 2021 02:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2021
@bcoe bcoe requested a review from codyoss January 15, 2021 02:32
bcoe and others added 2 commits January 15, 2021 14:58
Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
@bcoe bcoe requested a review from codyoss January 16, 2021 01:13
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like genlocal still need to be run again. Doing so will move the generated artifacts to a new folder. You might need to manually delete out the file that were generated in the wrong folder.

@codyoss codyoss changed the title feat(networkconnectivity): initial generation of v1alpha1 feat(networkconnectivity): initial generation of apiv1alpha1 Jan 19, 2021
@bcoe bcoe requested a review from codyoss January 25, 2021 17:36
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit adf489a into master Jan 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the networkconnectivity branch January 25, 2021 19:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants