Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add projection parameter for BucketHandle.Objects() #3549

Merged
merged 11 commits into from Jan 22, 2021

Conversation

ava12
Copy link
Contributor

@ava12 ava12 commented Jan 13, 2021

Closes #3445.

@ava12 ava12 requested review from tritone and a team as code owners January 13, 2021 21:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 13, 2021
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few comments...

storage/storage.go Outdated Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
storage/bucket_test.go Outdated Show resolved Hide resolved
@ava12 ava12 requested a review from tritone January 15, 2021 17:39
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Running gofmt should resolve the presubmit failure.

storage/storage.go Outdated Show resolved Hide resolved
@ava12 ava12 requested a review from tritone January 15, 2021 18:34
@ava12 ava12 requested a review from codyoss January 19, 2021 23:36
@tritone tritone requested a review from frankyn January 21, 2021 15:03
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @codyoss @frankyn feel free to chime in if you have thoughts.

@ava12 ava12 requested a review from codyoss January 22, 2021 16:28
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Jan 22, 2021
@tritone tritone merged commit 9b9c3dc into googleapis:master Jan 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 22, 2021
@ava12 ava12 deleted the storage-objects-projection branch April 2, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: add Projection to Query
4 participants