feat(bigquery): add support for allowing Javascript UDFs to indicate determinism #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigQuery supports javascript UDFs, which allow users to define function bodies to be executed via javascrtipt. Allowing users to indicate determinism level of the UDF helps the query engine make more efficient choices around aspects like query caching. Fixes: googleapis#3533
google-cla
bot
added
the
cla: yes
codyoss
changed the title
…cloud-go into fr-routine-determinism
product-auto-label
bot
added
the
api: bigquery
tswast
reviewed
Jan 13, 2021
| processed = true | ||
| } | ||
| if !processed { | ||
| panic(fmt.Sprintf("DeterminismLevel should be either type string or RoutineDetermism in update, got %T", rm.DeterminismLevel)) |
There was a problem hiding this comment.
Why panic instead of returning error?
There was a problem hiding this comment.
This mimics the behavior of the converters in https://pkg.go.dev/cloud.google.com/go/internal/optional. All the other fields panic if you use incorrect type, so yielding a custom error for the one field seems a mismatch.
tswast
approved these changes
Jan 14, 2021
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 14, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.15.0](https://www.github.com/googleapis/google-cloud-go/compare/bigquery/v1.14.0...v1.15.0) (2021-01-14) ### Features * **bigquery:** add reservation usage stats to query statistics ([#3403](https://www.github.com/googleapis/google-cloud-go/issues/3403)) ([112bcde](https://www.github.com/googleapis/google-cloud-go/commit/112bcdeb7cee1b44f337d3e5398a0d0820e93162)) * **bigquery:** add support for allowing Javascript UDFs to indicate determinism ([#3534](https://www.github.com/googleapis/google-cloud-go/issues/3534)) ([2f417a3](https://www.github.com/googleapis/google-cloud-go/commit/2f417a39d93402fbb1e5e3001645019782d7d656)), refs [#3533](https://www.github.com/googleapis/google-cloud-go/issues/3533) ### Bug Fixes * **bigquery:** address possible panic due to offset checking in handleInsertErrors ([#3524](https://www.github.com/googleapis/google-cloud-go/issues/3524)) ([5288511](https://www.github.com/googleapis/google-cloud-go/commit/52885115af3e95cdfd1ec784837fb1df7fe01446)), refs [#3519](https://www.github.com/googleapis/google-cloud-go/issues/3519) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Feb 1, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery supports javascript UDFs, which allow users to define function
bodies to be executed via javascrtipt. Allowing users to indicate
determinism level of the UDF helps the query engine make more efficient
choices around aspects like query caching.
Fixes: #3533