Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery: add Determinism to RoutineMetadata #3533

Closed
lightyear15 opened this issue Jan 12, 2021 · 2 comments · Fixed by #3534
Closed

bigquery: add Determinism to RoutineMetadata #3533

lightyear15 opened this issue Jan 12, 2021 · 2 comments · Fixed by #3534
Assignees
@shollyman
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@lightyear15
Copy link

lightyear15 commented Jan 12, 2021 •
edited

Client
BigQuery
package cloud.google.com/go/bigquery version v1.14.0

Expected behavior
struct RoutineMetadata containing a field to express function determinism, like in package
google.golang.org/api/bigquery/v2
where struct Routine has field DeterminismLevel

Actual behavior
No way to express level of determinism
@lightyear15 lightyear15 added the triage me I really want to be triaged. label Jan 12, 2021
@codyoss codyoss changed the title packagename: short description of bug bigquery: add Determinism to RoutineMetadata Jan 12, 2021
@codyoss codyoss added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jan 12, 2021
@shollyman
Copy link
Contributor

Will add this, but I don't understand the comment around message arrival. Could you elaborate?

shollyman added a commit to shollyman/google-cloud-go that referenced this issue Jan 12, 2021
@shollyman
feat: add support for allowing Javascript UDFs to indicate determinism
c50be46 
BigQuery supports javascript UDFs, which allow users to define function
bodies to be executed via javascrtipt.  Allowing users to indicate
determinism level of the UDF helps the query engine make more efficient
choices around aspects like query caching.

Fixes: googleapis#3533
@shollyman shollyman mentioned this issue Jan 12, 2021
Merged
@lightyear15
Copy link
Author

lightyear15 commented Jan 13, 2021 •
edited

Will add this, but I don't understand the comment around message arrival. Could you elaborate?

Oh sorry,
please ignore it
that was a left over from the issue template 😅

gcf-merge-on-green bot pushed a commit that referenced this issue Jan 14, 2021
@shollyman
feat(bigquery): add support for allowing Javascript UDFs to indicate …
2f417a3 
…determinism (#3534)

BigQuery supports javascript UDFs, which allow users to define function
bodies to be executed via javascrtipt.  Allowing users to indicate
determinism level of the UDF helps the query engine make more efficient
choices around aspects like query caching.

Fixes: #3533
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 14, 2021
@yoshi-code-bot
chore: release bigquery 1.15.0 (#3427)
3bac8dd 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.15.0](https://www.github.com/googleapis/google-cloud-go/compare/bigquery/v1.14.0...v1.15.0) (2021-01-14)


### Features

* **bigquery:** add reservation usage stats to query statistics ([#3403](https://www.github.com/googleapis/google-cloud-go/issues/3403)) ([112bcde](https://www.github.com/googleapis/google-cloud-go/commit/112bcdeb7cee1b44f337d3e5398a0d0820e93162))
* **bigquery:** add support for allowing Javascript UDFs to indicate determinism ([#3534](https://www.github.com/googleapis/google-cloud-go/issues/3534)) ([2f417a3](https://www.github.com/googleapis/google-cloud-go/commit/2f417a39d93402fbb1e5e3001645019782d7d656)), refs [#3533](https://www.github.com/googleapis/google-cloud-go/issues/3533)


### Bug Fixes

* **bigquery:** address possible panic due to offset checking in handleInsertErrors  ([#3524](https://www.github.com/googleapis/google-cloud-go/issues/3524)) ([5288511](https://www.github.com/googleapis/google-cloud-go/commit/52885115af3e95cdfd1ec784837fb1df7fe01446)), refs [#3519](https://www.github.com/googleapis/google-cloud-go/issues/3519)

This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@shollyman @codyoss @lightyear15