fix(datastore): Ensure the datastore time is returned as UTC #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: datastore
tbpg
suggested changes
Jan 11, 2021
| @@ -369,7 +369,7 @@ func setVal(v reflect.Value, p Property) (s string) { | |||
| if ok { | |||
| s := micros / 1e6 | |||
| ns := micros % 1e6 | |||
| v.Set(reflect.ValueOf(time.Unix(s, ns))) | |||
| v.Set(reflect.ValueOf(time.Unix(s, ns).In(time.UTC))) | |||
There was a problem hiding this comment.
Mind adding a test that ensures the times are returned in UTC?
There was a problem hiding this comment.
+1, might be easier said than done though :)
tritone
reviewed
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.