New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): attempt DirectPath by default #3516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this have latency implications for users who don't have access to DirecPath?
Not sure I 100% understand the question:
|
I guess my question is if this will disrupt users without DirectPath access. Would their requests make an extra round trip? Is that something we should call out prominently in the changelog? I bring it up because users tend to care about network changes (we get issues pretty frequently about various network things). I don't know -- this may have already been talked about. Up to @skuruppu. |
Users without DirectPath access should not be disrupted. The traffic will fallback to CFE as what is currently is, and users are not supposed to know this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks! Please wait for @skuruppu.
FYI @thiagotnunes |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Update client to attempt DirectPath by default.
Note that it doesn't mean that after this change client will just use DirectPath, but will call the DirectPath codepath by default.
The actually enablement of DirectPath is controlled by service owner via ACL config. For now, after this change, although all users will attempt DirectPath, but they will all just fallback to the original CFE path.