New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner/spannertest): support Not Null constraint #3491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part. A couple of extra bits that should be done in this same change.
No need to worry about a test; I assume you've exercised this with your own code already?
Thank you for the review!
Sure, I confirmed that inserting null into Not Null column was declined. |
About
Fixes #3490
Note
Not Null
, but, I've not done that in this PR. Assuming how the library users use this library, I suppose the check in writing a record is more prioritized.