Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): run E2E test over DirectPath #3466

Merged
merged 4 commits into from Dec 22, 2020
Merged

feat(spanner): run E2E test over DirectPath #3466

merged 4 commits into from Dec 22, 2020

Conversation

mohanli-ml
Copy link
Contributor

Run spanner-go integration tests over directpath traffic.

@mohanli-ml mohanli-ml requested review from skuruppu and a team as code owners December 15, 2020 04:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Dec 15, 2020
olavloite
olavloite approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a non-blocking question on using env vars instead of hard coding the addresses.

spanner/integration_test.go Show resolved Hide resolved
@thiagotnunes thiagotnunes merged commit 18e3a4f into googleapis:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohanli-ml @olavloite @thiagotnunes