feat(pubsublite): add client library metadata to headers #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
|
@codyoss: We'd like to send the pubsublite library version to the server for debugging purposes. |
tmdiep
force-pushed
the
pubsub_headers
branch
from
c25ca8b
to
69f3ff1
Compare
hongalex
approved these changes
Jan 7, 2021
codyoss
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Just one small comment or else seems good to me. Only other thing is that I think we need to document these additional headers somewhere(internal). That way things can be consistent across languages and people can tell what the values mean. It is very possible this is already done and I am oblivious though.
0xSage
pushed a commit
to 0xSage/google-cloud-go
that referenced
this pull request
Jan 8, 2021
…3458) Adds client library version and other properties to gRPC stream metadata for debugging purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds client library version and other properties to gRPC stream metadata for debugging purposes.