New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): support CommitStats #3444
Conversation
@skuruppu The current build failure seems to be caused by a test project that does not (yet) support |
Oh interesting. I think it's because it's not fully released in the backend. I'll give you a go ahead to rerun the tests when the release is complete. Thanks for rebasing the PR :) |
Hmmm still failing the test but I don't understand why.
|
@olavloite I can confirm that equivalent tests pass for all other languages so would you be able to check if it's an issue with the Go implementation? |
Hmmm... This is strange. If I run the above mentioned integration tests from my local environment against a normal test instance, the integration tests succeed. |
Never mind, the problem is that the build is failing when it is running the integration tests against the emulator, and that does not support commit stats yet. |
Adds support for
CommitStats
to the Spanner client.Based on #3056.