Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsublite): subscriber client #3442

Merged
merged 10 commits into from Jan 6, 2021
Merged

feat(pubsublite): subscriber client #3442

merged 10 commits into from Jan 6, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Dec 10, 2020

SubscriberClient wraps Pub/Sub Lite's wire.Subscriber and emulates the pubsub.Subscription.Receive API.

Not mergeable until dependent PRs have been committed to master.

@tmdiep tmdiep requested a review from a team as a code owner December 10, 2020 02:19
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Dec 10, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 10, 2020
@tmdiep
Copy link
Contributor Author

tmdiep commented Dec 10, 2020

WANT_LGTM=@dpcollins-google for Pub/Sub Lite logic, @hongalex for consistency with CPS. I've tried to replicate most of the documented behavior, e.g. waiting for all receiver funcs to finish before returning from Receive().

@tmdiep tmdiep removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 23, 2020
hongalex
hongalex approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor nits

pubsublite/ps/subscriber.go Outdated Show resolved Hide resolved
pubsublite/ps/example_test.go Show resolved Hide resolved
@tmdiep tmdiep merged commit 221bfba into googleapis:master Jan 6, 2021
@tmdiep tmdiep deleted the shim_subscriber branch January 6, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpcollins-google dpcollins-google dpcollins-google left review comments

@hongalex hongalex hongalex approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmdiep @hongalex @dpcollins-google