fix(pubsub): fix default stream ack deadline seconds #3430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A error was made in #3367 when using the default MaxExtensionPeriod of 0 seconds. This also made the default stream ack deadline seconds 0, which means messages will always expire and messages will never be successfully delivered. This PR reverts to the previous default of 60 seconds if MaxExtensionPeriod is disabled.
This issue fixes #3397, fixes #3398, fixes #3399