Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add reservation usage stats to query statistics #3403

Merged
merged 6 commits into from Dec 8, 2020

Conversation

shollyman
Copy link
Contributor

This PR plumbs through reservation usage stats reported per-job.

Also added a small integration test for testing query statistics,
as we didn't have one previously.

This PR plumbs through reservation usage stats reported per-job.

Also added a small integration test for testing query statistics,
as we didn't have one previously.
@shollyman shollyman requested a review from a team as a code owner December 7, 2020 19:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@shollyman shollyman changed the title feat: add reservation usage stats to query statistics feat(bigquery): add reservation usage stats to query statistics Dec 7, 2020
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

bigquery/integration_test.go Outdated Show resolved Hide resolved
bigquery/integration_test.go Outdated Show resolved Hide resolved
bigquery/job.go Outdated Show resolved Hide resolved
bigquery/job.go Show resolved Hide resolved
@shollyman
Copy link
Contributor Author

Just did a secondary review. This is a mirrored stat, hoisting this up outside of query stats.

@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2020
This is reported at the top-level, to support other slot-consuming
job types like load jobs.  We'll ignore the query-specific copy.
@shollyman shollyman removed the request for review from hongalex December 8, 2020 00:32
@shollyman shollyman removed cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 8, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@shollyman shollyman merged commit 112bcde into googleapis:master Dec 8, 2020
@shollyman shollyman deleted the fr-querystats branch December 8, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants