Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): loading civil types in non UTC location is incorrect #3376

Merged
merged 4 commits into from Dec 4, 2020
Merged

fix(datastore): loading civil types in non UTC location is incorrect #3376

merged 4 commits into from Dec 4, 2020

Conversation

IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Dec 4, 2020 •
edited

Fixes #3360

@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label Dec 4, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2020
@IlyaFaer IlyaFaer marked this pull request as ready for review December 4, 2020 07:24
@IlyaFaer IlyaFaer requested review from tritone and a team as code owners December 4, 2020 07:24
tritone
tritone approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @IlyaFaer.

FYI @dnerdy @crwilcox

tritone
tritone reviewed Dec 4, 2020
View reviewed changes
datastore/load_test.go Outdated Show resolved Hide resolved
@crwilcox crwilcox merged commit 9ac287d into googleapis:master Dec 4, 2020
@IlyaFaer IlyaFaer deleted the civil_non_utc branch December 7, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datastore: civil package types are loaded incorrectly when local machine timezone is not UTC
3 participants
@IlyaFaer @crwilcox @tritone