fix(pubsub): respect streamAckDeadlineSeconds with MaxExtensionPeriod #3367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamAckDeadlineSeconds
comes into effect when a stream shuts down prior to message modack (which the client library does automatically when a message is received). Users may want to lower this bound to decrease message redelivery times, which is specified byMaxExtensionPeriod
.This PR also refactors the field into the
pullOptions
struct, where it lies with themaxExtension
field.Fixes #3278