Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): support NUMERIC in mutations #3328

Merged
merged 5 commits into from Dec 10, 2020
Merged

feat(spanner): support NUMERIC in mutations #3328

merged 5 commits into from Dec 10, 2020

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Dec 2, 2020

This PR adds support of NUMERIC type in mutations.
ref #3327

@apstndb apstndb requested review from skuruppu and a team as code owners December 2, 2020 12:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Dec 2, 2020
@olavloite olavloite self-requested a review December 2, 2020 13:44
olavloite
olavloite approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing this.

It would have been good to have a test case that would note this in case there are new data types added in the future, but apparently that is missing. We can add that through a separate PR.

@olavloite olavloite mentioned this pull request Dec 3, 2020
Merged
@olavloite
Copy link
Contributor

@tbpg Do you have any idea why the kokoro run seems to be hanging indefinitely? I've tried to trigger the execution a number of times, but it never seems to finish (or report a status).

gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 4, 2020
@olavloite
test(spanner): add test for mutation with all data types (#3336)
5948715 
Adds an additional test case for the fix in #3328 

Updates #3327
@tbpg tbpg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 9, 2020
@tbpg
Copy link
Contributor

tbpg commented Dec 9, 2020

@olavloite, sorry, just saw this. I added the label to start Kokoro. Must have missed the initial webhook or something.

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 10, 2020
@olavloite olavloite merged commit fa90737 into googleapis:master Dec 10, 2020
@olavloite
Copy link
Contributor

@olavloite, sorry, just saw this. I added the label to start Kokoro. Must have missed the initial webhook or something.

No problem, thanks for looking into it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@apstndb @olavloite @tbpg @kokoro-team @skuruppu