Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): settings and message transforms for Cloud Pub/Sub shim #3281

Merged
merged 26 commits into from Dec 23, 2020

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 26, 2020

Adds settings and message transformers for the Cloud Pub/Sub shim package.

The shim implements various features in the Lite Java client library for feature parity, e.g. nack handler, custom message transformers, key extractor, etc. It also implements some features from the Go pubsub library, e.g. publish buffer byte limit.

@tmdiep tmdiep requested a review from a team as a code owner November 26, 2020 05:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Nov 26, 2020
@tmdiep
Copy link
Contributor Author

tmdiep commented Nov 26, 2020

WANT_LGTM= @hongalex, @manuelmenzella-google

Suggestions for the name of this package are welcome. I just called it ps to mirror pstest and don't have any better ideas, but think it may be too short.

pubsublite/ps/doc.go Outdated Show resolved Hide resolved
pubsublite/ps/message.go Show resolved Hide resolved
pubsublite/ps/settings.go Show resolved Hide resolved
pubsublite/ps/settings.go Show resolved Hide resolved
@tmdiep tmdiep force-pushed the shim_settings branch 2 times, most recently from 004891f to f8ebd1b Compare December 9, 2020 00:30
@tmdiep
Copy link
Contributor Author

tmdiep commented Dec 9, 2020

Sorry for the churn - I added a non-trivial amendment, as it's probably better to replicate CPS behavior and treat zero Publish/Receive settings as default settings. When we add more settings fields in the future, it's better to treat zero as defaults for back-compatibility.

@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@tmdiep tmdiep merged commit 74923c2 into googleapis:master Dec 23, 2020
@tmdiep tmdiep deleted the shim_settings branch December 23, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants