Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): assigning subscriber implementation #3238

Merged
merged 8 commits into from Dec 7, 2020

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Nov 19, 2020

assigningSubscriber uses the Pub/Sub Lite partition assignment service to listen to its assigned partition numbers and dynamically add/remove singlePartitionSubscribers.

@tmdiep tmdiep requested a review from a team as a code owner November 19, 2020 21:55
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@tmdiep
Copy link
Contributor Author

tmdiep commented Nov 19, 2020

WANT_LGTM=@dpcollins-google for checking assigner and assigningSubscriber logic.
Other reviewers optional. Feel free to leave comments.

@tmdiep tmdiep changed the title feat(pubsublite): Assigning subscriber feat(pubsublite): assigning subscriber implementation Nov 24, 2020
@tmdiep tmdiep force-pushed the subscriber2 branch 2 times, most recently from 92d9cd8 to 71ab99c Compare November 28, 2020 09:08
Copy link

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changes from a pub/sub lite perspective, I'd prefer if you get someone familiar with go to review as well.

pubsublite/internal/wire/assigner.go Show resolved Hide resolved
pubsublite/internal/wire/assigner.go Show resolved Hide resolved
pubsublite/internal/wire/assigner.go Show resolved Hide resolved
pubsublite/internal/wire/subscriber.go Show resolved Hide resolved
@tmdiep
Copy link
Contributor Author

tmdiep commented Dec 2, 2020

WANT_LGTM=@hongalex for Go, and also Dan doesn't have write access and can't approve anyway.

@tmdiep tmdiep merged commit d1c03da into googleapis:master Dec 7, 2020
@tmdiep tmdiep deleted the subscriber2 branch December 7, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants